Commit review: r26960 (scipad)

François Vogel fvogelnew1 at free.fr
Fri Aug 29 22:42:26 CEST 2008


Hi devlisters,

Reviewing the commits in Scipad I have noticed commit 26960:

http://viewvc.scilab.org/bin/cgi/viewvc.cgi/trunk/scilab/modules/scipad/macros/scipad_internals/dynamickeywords.sce?r1=22996&r2=26960

I'm wondering why this had to be added?

The commit log says "checks that interp exists", which is pretty 
obvious from the code itself, but doesn't give a hint about why 
checking Tcl interpreter existence was needed here.

Indeed, function setscipadwords is part of Scipad internals. It is 
only called from within Scipad during its launch. Therefore the added 
test if TCL_ExistInterp('scipad') always return true.

So, could you please clarify why this was needed?

Thank you for enlightening me.

Francois



More information about the dev mailing list