[Scilab-Dev] sci_gateway/c/sci_base2dec.c:84: bad if test ?

[Sylvestre Ledru]

On 23/09/2013 10:20, David Binderman wrote:
> Hello there,
> 
> I just ran the static analyser "cppcheck" over the source code
> of scilab-5.4.1.
> 
> It said many things, including this
> 
> [sci_gateway/c/sci_base2dec.c:84]: (warning) Logical conjunction always evaluates to false: iValue < 2 && iValue> 36.
> 
> Suggest swap && for ||. Same problem in a different place
> 
> [sci_gateway/c/sci_dec2base.c:114]: (warning) Logical conjunction always evaluates to false: iBaseUsed < 2 && iBaseUsed> 36.
Looks like potential bugs.

However, you should run such tools on the master branch. We do a lot of
fixes...

Sylvestre