[Scilab-Dev] sci_gateway/c/sci_base2dec.c:84: bad if test ?

[David Binderman]

Hello there,

I just ran the static analyser "cppcheck" over the source code
of scilab-5.4.1.

It said many things, including this

[sci_gateway/c/sci_base2dec.c:84]: (warning) Logical conjunction always evaluates to false: iValue < 2 && iValue> 36.

Suggest swap && for ||. Same problem in a different place

[sci_gateway/c/sci_dec2base.c:114]: (warning) Logical conjunction always evaluates to false: iBaseUsed < 2 && iBaseUsed> 36.

Regards

David Binderman