<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Marcos,<br>
<br>
On 27/04/2012 16:22, Marcos Cardinot wrote:
<blockquote
cite="mid:CAHK912UM-tRLf1gQ64tVDtW3rgGj=a7QBjoN8OODrHZi_MFKMA@mail.gmail.com"
type="cite">
<div class="gmail_extra">Hi,<br>
<div class="gmail_quote"><br>
I was studying in a datatip codes and found a bug that
happened when the user wants to drag a datatip. Initially, I
thought there was some problem with the file datatipMove.sci.<br>
<br>
After performing some tests, I found that the error is in the
xgetmouse function, which is not providing coordinate data
correctly (always returns 0 and 0).<br>
<br>
After running git blame on sci_xgetmouse.c, I discovered that
the bug was introduced during commit"
582dead8368ac857e5b3ddd1c64360
<div>716da76887<br>
<br>
I checked a few lines that were commented out and that the
"pixelCoords" was not being passed to the scilab stack.<br>
<br>
After these changes the function xgetmouse is working well
and datatip bug no longer exists. Now you can drag datatip
normally.<br>
<br>
I do not know if the rows removed lines in my patch have to
do with coordinates in sub-plots, but according to my tests
everything seems to be working fine.<br>
<br>
Should I open a bug, even though I am already submitting a
patch?<br>
<br>
</div>
</div>
</div>
</blockquote>
Did you check if this bug has not been reported before ?<br>
For now, I pushed it in the code review:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="http://codereview.scilab.org/#/c/7067/">http://codereview.scilab.org/#/c/7067/</a><br>
<blockquote
cite="mid:CAHK912UM-tRLf1gQ64tVDtW3rgGj=a7QBjoN8OODrHZi_MFKMA@mail.gmail.com"
type="cite">
<div class="gmail_extra">
<div class="gmail_quote">
<div>Also, do you think I should leave the commented-out
lines?<br>
I am not sure if they can be useful in the future. <br>
</div>
</div>
</div>
</blockquote>
It depends but usually, it prefer to remove comments, the
information remains available in the git history.<br>
<br>
Well done!<br>
<br>
Sylvestre<br>
</body>
</html>