<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<p>Hello Nikhil,</p>
<p>Thank you for your patch, <a
href="https://codereview.scilab.org/#/c/18852">here</a> is the
commit at your name! The help page was only translated in
japanese, I handled it.<br>
</p>
<p>Best regards,</p>
<p>Paul<br>
</p>
<br>
<div class="moz-cite-prefix">On 01/05/2017 04:23 PM, nikhil goel
wrote:<br>
</div>
<blockquote
cite="mid:CAEFPb7zY7kDuG6eyMwNCeQV1T-TaD+jzWyO00_DshqPh5CR_tA@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Clement,<br>
<br>
<div>I apologize for the delayed response. I have attached the
updated patch.<br>
All the modifications are done in a single commit.<br>
I was not too sure about the English documentation. I added
the term 'name' in figure_property in en_us help. Should I do
this for other languages as well?<br>
Also I updated my name in the Copyright lines.<br>
If there are any other mistakes, please let me know.<br>
<br>
Thanks<br>
Nikhil</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jan 4, 2017 at 1:17 PM, Clément
David <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:clement.david@scilab-enterprises.com"
target="_blank">clement.david@scilab-enterprises.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Nikhil,<br>
<br>
Thanks for the patches, for such a correction we expect all
the modification in a single commit so<br>
you should `git commit --amend`.<br>
<br>
We also require the updated english documentation to ensure
consistency. The documentation is<br>
written in XML files and I suggest you to use `git grep` to
found the references to "figure_name".<br>
<br>
Could you also update your name on the Copyright lines
please ?<br>
<br>
Thanks,<br>
<br>
--<br>
Clément<br>
<div class="HOEnZb">
<div class="h5"><br>
Le mercredi 04 janvier 2017 à 11:32 +0530, nikhil goel a
écrit :<br>
> Hello<br>
><br>
> Attached below is the patch for bug 14483. The
patch is in 2 parts. First part has the non<br>
> regression test and the second part has the changes
along with <a moz-do-not-send="true"
href="http://changes.md" rel="noreferrer"
target="_blank">changes.md</a> file.<br>
><br>
> If you could please review the changes and see if
things are in order.<br>
><br>
> Thanks<br>
><br>
> Nikhil<br>
><br>
> On Tue, Jan 3, 2017 at 12:58 PM, Clément David <<a
moz-do-not-send="true"
href="mailto:clement.david@scilab-enterprises.com">clement.david@scilab-<wbr>enterprises.com</a>>
wrote:<br>
> > Hi Nikhil and welcome,<br>
> ><br>
> > I saw your mail and accepted it but a bit late
:). About the process, we usually do not assign a<br>
> > bug<br>
> > to new-comers as the Assignee field is just a
reminder for us. You should select a bug, fix it<br>
> > and<br>
> > either mail the patch (using `git
format-patch`) or push it to the codereview (and add a<br>
> > reviewer).<br>
> ><br>
> > All (and probably too much :) ) information
are on the <a moz-do-not-send="true"
href="http://wiki.scilab.org" rel="noreferrer"
target="_blank">wiki.scilab.org</a>, do not hesitate
to use<br>
> > the<br>
> > gsoc ML for beginners question (compiling
scilab, commit and push a patch).<br>
> ><br>
> > Thanks,<br>
> ><br>
> > --<br>
> > Clément<br>
> ><br>
> > Le lundi 02 janvier 2017 à 13:12 +0530, nikhil
goel a écrit :<br>
> > > Sir/ Ma'am<br>
> > > I am Nikhil Goel, a second year
engineering student from BITS Pilani, India. I am
currently an<br>
> > > amateur coder and would like to
contribute in Scilab to learn more about software
development<br>
> > > practices.<br>
> > > I had sent a mail two weeks ago but I
wasn't subscribed to the dev mailing list. <br>
> > > Within this period I have developed a
deeper understanding of work flow and the code of<br>
> > scilab.<br>
> > > After becoming familiar with the
compilation of the software solved a bug that was
reported on<br>
> > > <a moz-do-not-send="true"
href="http://bugzilla.scilab.org" rel="noreferrer"
target="_blank">bugzilla.scilab.org</a>. but I havent
submitted the patch yet as I am unclear on the process.<br>
> > > Pointers/ suggestions on what to solve
would be greatly appreciated.<br>
> > > As I get more comfortable with the tech
stack, I would like to further contribute more<br>
> > > substantially.<br>
> > > Thanking you in anticipation <br>
> > > Regards <br>
> > > Nikhil Goel<br>
> > > ______________________________<wbr>_________________<br>
> > > dev mailing list<br>
> > > <a moz-do-not-send="true"
href="mailto:dev@lists.scilab.org">dev@lists.scilab.org</a><br>
> > > <a moz-do-not-send="true"
href="http://lists.scilab.org/mailman/listinfo/dev"
rel="noreferrer" target="_blank">http://lists.scilab.org/<wbr>mailman/listinfo/dev</a><br>
> > ______________________________<wbr>_________________<br>
> > dev mailing list<br>
> > <a moz-do-not-send="true"
href="mailto:dev@lists.scilab.org">dev@lists.scilab.org</a><br>
> > <a moz-do-not-send="true"
href="http://lists.scilab.org/mailman/listinfo/dev"
rel="noreferrer" target="_blank">http://lists.scilab.org/<wbr>mailman/listinfo/dev</a><br>
> ><br>
><br>
> ______________________________<wbr>_________________<br>
> dev mailing list<br>
> <a moz-do-not-send="true"
href="mailto:dev@lists.scilab.org">dev@lists.scilab.org</a><br>
> <a moz-do-not-send="true"
href="http://lists.scilab.org/mailman/listinfo/dev"
rel="noreferrer" target="_blank">http://lists.scilab.org/<wbr>mailman/listinfo/dev</a><br>
______________________________<wbr>_________________<br>
dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:dev@lists.scilab.org">dev@lists.scilab.org</a><br>
<a moz-do-not-send="true"
href="http://lists.scilab.org/mailman/listinfo/dev"
rel="noreferrer" target="_blank">http://lists.scilab.org/<wbr>mailman/listinfo/dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dev@lists.scilab.org">dev@lists.scilab.org</a>
<a class="moz-txt-link-freetext" href="http://lists.scilab.org/mailman/listinfo/dev">http://lists.scilab.org/mailman/listinfo/dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Paul BIGNIER
Development engineer
-----------------------------------------------------------
Scilab Enterprises
143bis rue Yves Le Coz - 78000 Versailles, France
Phone: +33.1.80.77.04.68
<a class="moz-txt-link-freetext" href="http://www.scilab-enterprises.com">http://www.scilab-enterprises.com</a></pre>
</body>
</html>