<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Clément,<br>
<br>
<blockquote cite="mid:1517935331.2145.36.camel@esi-group.com"
type="cite">
<pre wrap="">Le jeudi 01 février 2018 à 00:23 +0100, Samuel Gougeon a écrit :
</pre>
<blockquote type="cite">
<pre wrap="">Le 31/01/2018 à 20:45, Samuel Gougeon a écrit :
</pre>
<blockquote type="cite">
<pre wrap="">When we review files in diff mode, the edit icon switching the diff mode into the edit one at
the top of the diff page no longer works: it yields an error page.
</pre>
</blockquote>
<pre wrap="">
After some work, this proves to occur only for files whose names start with "%", which is a
special character for URLs.
So, it is likely a bug in CodeReview itself, not in the Scilab infrastructure (unless managing "%"
in filenames is configurable in CodeReview).
Samuel
</pre>
</blockquote>
</blockquote>
<br>
<div class="moz-cite-prefix">Le 06/02/2018 à 17:42, Clément David a
écrit :<br>
</div>
<blockquote cite="mid:1517935331.2145.36.camel@esi-group.com"
type="cite">
<pre wrap="">Hello Samuel,
Great notice ! This issue arise when the codereview server it out of disk space. This is a
notifiable behavior that might be fixed in more recent Gerrit version. You can continue working on
the patchset by using gerrit tools [1] or by crafting the cherry-pick URL by hand.
[1]: <a class="moz-txt-link-freetext" href="https://gerrit-review.googlesource.com/Documentation/cmd-cherry-pick.html">https://gerrit-review.googlesource.com/Documentation/cmd-cherry-pick.html</a>
</pre>
</blockquote>
<br>
The issue is really a Gerrit one, not a disk space issue on the
server.<br>
<br>
For instance, if we go here: <a class="moz-txt-link-freetext" href="https://codereview.scilab.org/19781">https://codereview.scilab.org/19781</a><br>
(before being merged ;)<br>
<img src="cid:part1.A4B86EC6.A970BAA7@free.fr" alt="" height="105"
width="439"><br>
and we click on the <b>%</b>s_k_i.sci file in the list while we are
in Editing mode ("Done Editing" flag),<br>
then it's OK : the file is properly edited in the Gerrit editor.<br>
<br>
Now, let's <br>
<ul>
<li>quit the Edition mode</li>
<li>click on the same file in the list, to view its diff</li>
<li>At the top of its diff (also according to your Gerrit
Preferences), click on the "Edit" icon<br>
<img src="cid:part2.0BD016A3.3B321084@free.fr" alt=""
height="52" width="554"></li>
<li>Then, we get an error :<span class="gwt-InlineLabel"><br>
<i>Not Found</i></span><i>: The page you requested was not
found, or you do not have permission to view this page.</i></li>
</ul>
<p>Actually, the "%" character of the file name is correctly
protected in the first case (we get %2525s_k_i_sci in the URL),
but not enough protected in the second way.</p>
<p>I don't know if this issue is reported in the Gerrit bug tracker
(if any).<br>
</p>
<p>Samuel</p>
<p><br>
</p>
</body>
</html>