<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hahaha it was me \o/<br>
<br>
Seriously, I don't care about localization in test.<br>
A long time ago we had a discussion about localization in tests.<br>
I would have preferred to have some tests about localization
mechanism and no localization in the others.<br>
The goal of all tests is <b>not</b> to check localization.<br>
But the final decision was different.<br>
<br>
In your commit you have mix localization and no localization, so I
update to full localization that's all.<br>
<br>
Antoine<br>
<div class="moz-cite-prefix">Le 14/06/2019 à 00:38, Samuel Gougeon a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:6babaebf-6c0d-39ab-62bf-2fcdcb04dc12@free.fr">Hello
Clément,
<br>
<br>
Le 13/06/2019 à 15:02, Clément David a écrit :
<br>
<blockquote type="cite">Hello Samuel,
<br>
<br>
There should be no real difference, having ENGLISH IMPOSED might
have subtle bugs related to the
<br>
system locales whereas using gettext() will rely on an extra
Scilab function call (so will be less a
<br>
"unit test").
<br>
<br>
IMHO commits having only this kind of diff is useless; there
should be something else, could you
<br>
point us the related code-review ?
<br>
</blockquote>
<br>
Both cases i had in mind were not commited just for this. But this
change was made in addition before merging.
<br>
Here is one case :
<br>
<br>
<a class="moz-txt-link-freetext" href="https://codereview.scilab.org/#/c/20723/6..7">https://codereview.scilab.org/#/c/20723/6..7</a>
<br>
<br>
There was another one around the 6.0.2 release, but i failed
refinding it.
<br>
<br>
I agree about the extra function call. But as i wrote before, i
got aware that using gettext() rather than ENGLISH IMPOSED is more
robust for (rare but possible) cases having a translation even for
en_US.
<br>
<br>
Regards
<br>
Samuel
<br>
<br>
_______________________________________________
<br>
dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:dev@lists.scilab.org">dev@lists.scilab.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.scilab.org/mailman/listinfo/dev">http://lists.scilab.org/mailman/listinfo/dev</a>
<br>
</blockquote>
<br>
</body>
</html>