Commit review on d53105f2fc72e7a7d949a3b055f915411d373784 (xs2emf, xs2fig)

François Vogel fvogelnew1 at free.fr
Mon Dec 8 21:34:53 CET 2008


Hi,

Lurking at the commits today, I stumbled on 
d53105f2fc72e7a7d949a3b055f915411d373784

The diff says:

catch		
	if win64() then
		messagebox(msg, "Scilab error", "error")
-	else
-		messagebox(msg, "Scilab error", "error")
	end				
	return;
end


Is this intentional?
Why removing the messagebox if ~win64()?

Shouldn't this commit rather read:

catch		
_	if win64() then
		messagebox(msg, "Scilab error", "error")
-	else
-		messagebox(msg, "Scilab error", "error")
-	end				
	return;
end


What am I missing here?

Francois




More information about the dev mailing list