[Scilab-Dev] Contributing to scilab

[Clément David]

Hi Nikhil,

Thanks for the patches, for such a correction we expect all the modification in a single commit so
you should `git commit --amend`.

We also require the updated english documentation to ensure consistency. The documentation is
written in XML files and I suggest you to use `git grep` to found the references to "figure_name".

Could you also update your name on the Copyright lines please ?

Thanks,

--
Clément

Le mercredi 04 janvier 2017 à 11:32 +0530, nikhil goel a écrit :
> Hello
> 
> Attached below is the patch for bug 14483. The patch is in 2 parts. First part has the non
> regression test and the second part has the changes along with changes.md file.
> 
> If you could please review the changes and see if things are in order.
> 
> Thanks
> 
> Nikhil
> 
> On Tue, Jan 3, 2017 at 12:58 PM, Clément David <clement.david at scilab-enterprises.com> wrote:
> > Hi Nikhil and welcome,
> > 
> > I saw your mail and accepted it but a bit late :). About the process, we usually do not assign a
> > bug
> > to new-comers as the Assignee field is just a reminder for us. You should select a bug, fix it
> > and
> > either mail the patch (using `git format-patch`) or push it to the codereview (and add a
> > reviewer).
> > 
> > All (and probably too much :) ) information are on the wiki.scilab.org, do not hesitate to use
> > the
> > gsoc ML for beginners question (compiling scilab, commit and push a patch).
> > 
> > Thanks,
> > 
> > --
> > Clément
> > 
> > Le lundi 02 janvier 2017 à 13:12 +0530, nikhil goel a écrit :
> > > Sir/ Ma'am
> > > I am Nikhil Goel, a second year engineering student from BITS Pilani, India. I am currently an
> > > amateur coder and would like to contribute in Scilab to learn more about software development
> > > practices.
> > > I had sent a mail two weeks ago but I wasn't subscribed to the dev mailing list. 
> > > Within this period I have developed a deeper understanding of work flow and the code of
> > scilab.
> > > After becoming familiar with the compilation of the software solved a bug that was reported on
> > > bugzilla.scilab.org. but I havent submitted the patch yet as I am unclear on the process.
> > > Pointers/ suggestions on what to solve would be greatly appreciated.
> > > As I get more comfortable with the tech stack, I would like to further contribute more
> > > substantially.
> > > Thanking you in anticipation 
> > > Regards 
> > > Nikhil Goel
> > > _______________________________________________
> > > dev mailing list
> > > dev at lists.scilab.org
> > > http://lists.scilab.org/mailman/listinfo/dev
> > _______________________________________________
> > dev mailing list
> > dev at lists.scilab.org
> > http://lists.scilab.org/mailman/listinfo/dev
> > 
> 
> _______________________________________________
> dev mailing list
> dev at lists.scilab.org
> http://lists.scilab.org/mailman/listinfo/dev