[Scilab-Dev] Disturbing changes on CodeReview

[Samuel Gougeon]

Hello Clément,

> Le jeudi 01 février 2018 à 00:23 +0100, Samuel Gougeon a écrit :
>> Le 31/01/2018 à 20:45, Samuel Gougeon a écrit :
>>> When we review files in diff mode, the edit icon switching the diff mode into the edit one at
>>> the top of the diff page no longer works: it yields an error page.
>>   
>> After some work, this proves to occur only for files whose names start with "%", which is a
>> special character for URLs.
>> So, it is likely a bug in CodeReview itself, not in the Scilab infrastructure (unless managing "%"
>> in filenames is configurable in CodeReview).
>>
>> Samuel

Le 06/02/2018 à 17:42, Clément David a écrit :
> Hello Samuel,
>
> Great notice ! This issue arise when the codereview server it out of disk space. This is a
> notifiable behavior that might be fixed in more recent Gerrit version. You can continue working on
> the patchset by using gerrit tools [1] or by crafting the cherry-pick URL by hand.
>
> [1]: https://gerrit-review.googlesource.com/Documentation/cmd-cherry-pick.html
>

The issue is really a Gerrit one, not a disk space issue on the server.

For instance, if we go here: https://codereview.scilab.org/19781
(before being merged ;)

and we click on the *%*s_k_i.sci file in the list while we are in 
Editing mode ("Done Editing" flag),
then it's OK : the file is properly edited in the Gerrit editor.

Now, let's

  * quit the Edition mode
  * click on the same file in the list, to view its diff
  * At the top of its diff (also according to your Gerrit Preferences),
    click on the "Edit" icon
  * Then, we get an error :
    /Not Found//: The page you requested was not found, or you do not
    have permission to view this page./

Actually, the "%" character of the file name is correctly protected in 
the first case (we get %2525s_k_i_sci in the URL), but not enough 
protected in the second way.

I don't know if this issue is reported in the Gerrit bug tracker (if any).

Samuel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.scilab.org/pipermail/dev/attachments/20180226/46b8d87b/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hepboggpdebbmllh.png
Type: image/png
Size: 12006 bytes
Desc: not available
URL: <https://lists.scilab.org/pipermail/dev/attachments/20180226/46b8d87b/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gomlcnpiapiibhbp.png
Type: image/png
Size: 15106 bytes
Desc: not available
URL: <https://lists.scilab.org/pipermail/dev/attachments/20180226/46b8d87b/attachment-0001.png>