[Scilab-Dev] tests: <-- ENGLISH IMPOSED --> removed and gettext() added: why?

[Clément David]

Hello Samuel,

There should be no real difference, having ENGLISH IMPOSED might have subtle bugs related to the
system locales whereas using gettext() will rely on an extra Scilab function call (so will be less a
"unit test").

IMHO commits having only this kind of diff is useless; there should be something else, could you
point us the related code-review ?

Thanks,

--
Clément


Le vendredi 31 mai 2019 à 18:57 +0200, Samuel Gougeon a écrit :
> Hello,
> In some commits just before the release of 6.0.2, and more recently on the master, i noticed that
> when some tests are tagged with the <-- ENGLISH IMPOSED --> flag and some error messages are
> tested against their english version, without calling gettext, the reviewer removes the flag and
> adds gettext().
> 
> What's the reason for this? What's the purpose of the <-- ENGLISH IMPOSED --> flag, then ?
> Theoretically, the message in english can be different from the message_id (also in english).
> Is it the reason? Or what else?
> Thanks for your insight about this topic.
> Regards
> Samuel
> 
> _______________________________________________
> dev mailing list
> dev at lists.scilab.org
> http://lists.scilab.org/mailman/listinfo/dev